binaryage / binaryage/cljs-devtools
Firefox overrides break native-reference-wrapper-style
- 主要语言
- Clojure
- 星标
- 1.1k
- 派生
- 51
- PR 合并指标
- 30 天内没有已合并 PR
描述
It took me a while to figure out why in the [re-frame-10x](https://github.com/day8/re-frame-10x) view of my Re-frame data, from a certain point in time, the panel gets largely erased, looking as follows (the right half of the screenshot is the panel):

Having grepped through the code of that library and then of cljs-devtools, I figured out the Firefox overrides are apparently to blame -- causing this "native reference wrapper" to lose its "position: relative" style, which in turn results in its first child (effectively "position: absolute; inset: 1px", as defined by `get-inner-background-style`) to take much more space than intended. In the context of the Re-frame-10x debugging panel, it grows to fill the entire panel with its white background.
Indeed, in Chromium, the Re-frame-10x panel works fine:

I can imagine two reasonable solutions:
1. Add the "position: relative" specification (and maybe "display: inline-flex", too?) also to the native-reference-wrapper-style config in the Firefox overrides.
2. Make the CSS values specified in the overrides _extend_ the defaults instead of replacing them.
I don't know enough about why the overrides are configured as they are currently configured, so I am also not sure which would be the right way to proceed. For now, I will try to patch this bug in my user config.
贡献指南
这个仓库没有索引到贡献指南
调研方向
检查 Firefox overrides 和 native-reference-wrapper-style 配置,然后在 re-frame-10x 视图中复现该问题。确定 override 应保留原生 wrapper 的定位方式,还是扩展默认值;当 panel 在 Firefox 中正确渲染且子元素背景不会填满 panel 时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- css
- 领域
- devtools, frontend
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100