binaryage / binaryage/cljs-devtools

Generalize code and documentation to include Firefox

未关闭
#71 1 条评论 3 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Clojure
星标
1.1k
派生
51
PR 合并指标
30 天内没有已合并 PR

描述

An [implementation for custom formatters in Firefox](https://bugzilla.mozilla.org/show_bug.cgi?id=1734614) is on its way. So the code and documentaton of the CLJS DevTools should account for that.

Currently, there's an [explicit check for Chrome 47 in the formatters code](https://github.com/binaryage/cljs-devtools/blob/4b4e256019f58ca7b3227a68ab2606664c95a906/src/lib/devtools/formatters.cljs#L17).

One possibility would be to simply remove the check and the logic around it as browsers not supporting custom formatters simply display the logged objects with their normal rendering.
The downside of that approach is, of course, that there won't be a hint anymore when the custom formatters couldn't be applied.

And the documentation is also still very much focused on Chrome as browser. Once the implementation in Firefox stands, all mentions in the documentation should reflect that. This means, adding Firefox where necessary or removing the wording related to Chrome where possible.

Sebastian

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start by checking the linked Firefox implementation status, then read src/lib/devtools/formatters.cljs around the explicit Chrome 47 check. Review the documentation for Chrome-specific wording and determine how formatter support should be represented when browsers lack it; done means the code and documentation account for Firefox without losing appropriate user guidance.

由索引模型根据 Issue 内容生成。

评估

技术栈
clojure
领域
documentation, tooling
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。