beyondcode / beyondcode/polyscope-community

[Bug] Worktree creation generates broken Nginx config for Herd

Abierto
#80 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Sin datos de lenguaje
Estrellas
20
Forks
0
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

## Description

When Polyscope creates a worktree, it appears to register a new site in Laravel Herd's Nginx configuration. However, the generated config file contains empty replacement strings, which causes Nginx to fail to start entirely.

## Version

- Polyscope: **0.14.0**
- Laravel Herd (macOS)

## Steps to reproduce

1. Use Polyscope to create a worktree (e.g. for a PR)
2. Herd's Nginx server crashes and fails to restart

## Root cause

The generated Nginx site config (in `~/Library/Application Support/Herd/config/valet/Nginx/`) contains empty strings where paths should be:

```nginx
location / {
rewrite ^ "" last; # ← empty replacement, invalid in Nginx
}

error_page 404 ""; # ← empty
fastcgi_index ""; # ← empty
fastcgi_param SCRIPT_FILENAME ""; # ← empty
```

Nginx throws:
```
[emerg] empty replacement in .../config/valet/Nginx/jolly-newt.test:28
nginx: configuration file ... test failed
```

This prevents **all** Herd sites from working, not just the Polyscope worktree site.

## Expected behavior

The generated Nginx config should contain valid paths pointing to the worktree directory, or the site should not be registered in Herd if the paths are unavailable.

## Workaround

Manually delete the broken config file from `~/Library/Application Support/Herd/config/valet/Nginx/` and restart Herd.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.