bedapub / bedapub/besca

Pending improvements in the Silhouette Computation function

Open
#171 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
50
Forks
17
Avg merge
1d 4h
Merged PRs (30d)
3

Description

In the `silhouette_computation ` function there are some comments about improvements that should be made in the plots (see below). Do you plan to include this later? Or did you just forget to include these improvements?

```
# TODO ADD PROPER TITLE/ AXIS/ MEAN OVERALL and mean per label ?
ax1 = sns.violinplot(
y=long_df_silhouette["label"], x=long_df_silhouette["silhouette"], scale="count"
)
matplotlib.pyplot.close() # Avoid plooting in function; bad practice
silhouette_results = silhouette_in(ax1, silhouette_avg)

return silhouette_results
```

Best,
Alberto

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the `silhouette_computation` function and reviewing the shown violin-plot code and its `silhouette_in` call. The work is complete when the plot has a proper title and axis labels, includes the requested overall and per-label means if appropriate, and avoids plotting as a side effect of the function.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.