bbcmicrobit / bbcmicrobit/PythonEditor

Moving between versions should preserve contents of buffer

Offen
#19 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
JavaScript
Sterne
201
Forks
126
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Since 0.1.0 we've been able to move between different versions of the editor. Hooray!

However, currently the contents of the script buffer (IE the users' code) gets lost between this version migration. In the case that the user entered with a script in the URL we will preserve that script but not any subsequent changes.

I believe the following rule is good:

> Whenever moving between editor versions, put the buffer contents into the URL bar so that the script migrates between versions

Implementation-wise there are a few privacy gotchas - If we put their script in the URL bar then it can/could end up in server logs. If we put it in a cookie we have to mention that we will use cookies in privacy policy.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.