bazelbuild / bazelbuild/rules_java
Fix return type for JavaInfo.getSourceJars()
- Dominant language
- Starlark
- Stars
- 103
- Forks
- 102
- PR merge metrics
- No merged PRs in 30d
Description
getSourceJars() returns SkylarkList now.
Should be NestedSet as was before in JavaSkylarkApiProvider and to be consistent with other methods which returns collection of Jar files.
Also consider some cleaning in scope of this task, as this method can be already used by someone.
Contributor guide
Research direction
Start by locating JavaInfo.getSourceJars() and the related JavaSkylarkApiProvider API. Compare its current SkylarkList return type with the prior NestedSet type and the other collection-returning methods, then inspect existing uses before deciding what cleanup is in scope. Done means the API type is corrected and affected uses remain consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100