bazelbuild / bazelbuild/rules_java

java_test: make it work for multiple junit tests and non tests sources without Skylark wrapper and dependent library

Open
#330 21 comments 10 reactions 0 assignees View on GitHub
P3
Dominant language
Starlark
Stars
103
Forks
102
PR merge metrics
No merged PRs in 30d

Description

`java_test` rule doesn't work as I would expect it should. I would expect to write this and provide mixed Junit tests and utility (also not tests classes) to the `srcs` glob.

Buck version:

```
java_test(
name = 'evict_cache_tests',
srcs = glob(['src/test/java/**/*.java']),
)
```

This doesn't work. Instead, I need this Skylark wrapper to generate JUnit Suites for me: [1]. Even then, it doesn't work because I must separate the utility library with non test sources from the JUnit test sources.

Bazel version:

```
load("//tools/bzl:junit.bzl", "junit_tests")

java_library(
name = "evict_test_utills",
srcs = glob([]),
)

junit_tests(
name = "evict_cache_tests",
srcs = glob(["src/test/java/**/*Test.java"]),# this would only pick test sources
deps = [":evict_test_utills"],
)
```

[1] https://github.com/GerritCodeReview/gerrit/blob/master/tools/bzl/junit.bzl

Contributor guide

Open the contributing guide

Research direction

Start by examining the java_test rule and the referenced tools/bzl:junit.bzl wrapper in the issue. Trace how mixed JUnit test and utility sources are handled, including the separate java_library dependency, and define done as allowing the shown java_test glob without a Skylark wrapper or separate dependent library.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.