bazel-contrib / bazel-contrib/rules_python
Support adding patch_cmds in pip.override
- Dominant language
- Starlark
- Stars
- 688
- Forks
- 721
- Avg merge
- 14h 49m
- Merged PRs (30d)
- 81
Description
# 🚀 feature request
### Description
Currently, the following exists for patching targets. However, for certain targets like pytorch, we have custom commands that patch the rpath of shared object libraries in our current workspace. However, this isn't doable with pip.override as we can't quite generate a patch for rpath differences. We can't patch the wheel beforehand because we're using pip torch relies on an rpath that is variable to change depending on the sha256sum of the wheel so we have to patch after the wheel is built as we can't know the sha256sum of the wheel before it's built
```
pip.override(
file = ".whl",
patch_strip = 1,
patches = [
"",
],
)
```
### Describe the solution you'd like
ideally if pip.override has a `patch_cmds` optional argument that would be great
```
pip.override(
file = ".whl",
patch_strip = 1,
patches = [
"",
],
patch_cmds = [
]
)
```
### Describe alternatives you've considered
We've tried patching before the wheel is built, but like the description above says, it's currently a chicken and egg problem
Contributor guide
Assessment
This issue has not been assessed yet.