bazel-contrib / bazel-contrib/rules_python

Gazelle target generation (breaking) changed in 1.6.0

Abierto
#3,499 0 comentarios 0 reacciones 0 asignados Ver en GitHub
gazelle
Lenguaje dominante
Starlark
Estrellas
688
Forks
721
Merge medio
15 h 7 min
PR fusionados (30 d)
76

Descripción

# 🐞 bug report

### Affected Rule

`py_test`/`py_library` (and Gazelle, not a rule)

### Is this a regression?

I'd argue so 😓. https://github.com/bazel-contrib/rules_python/pull/2998 introduced the new behavior (released in 1.6.0).

(more details in description)

### Description

(Before I begin, please note I _like_ https://github.com/bazel-contrib/rules_python/pull/2998 as a change. I just don't like a seemingly breaking change without any warning or toggles or migration path).

I'm upgrading my work monorepo `rules_python` to the latest, version-by-version. `1.6.0` has apparently become a very hard stop on my journey, due to incompatible gazelle changes. At a high level this is because:

- After upgrade, `gazelle` is happy to add new targets, while leaving the old targets alone
- There's no way to emulate the old behavior. The closest is trying different `# gazelle:python_generation_mode`s to see what gives me a small (enough) diff
- There's no way to incrementally roll this out (e.g. the result is one mega-PR)
- Whereas the old way made it so you could cleverly solve import cycles (across multiple subdirs) the new way makes that challenging
- [conftest inclusion is a bit broken](https://github.com/bazel-contrib/rules_python/issues/3497)

## 🔬 Minimal Reproduction

(I'll try and work on a demo repo showing each of the bullet points above, bear with me)

## 🔥 Exception or Error

(N/A)

## 🌍 Your Environment

(N/A)

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by reviewing PR #2998 and the Gazelle python_generation_mode behavior, comparing generated targets before and after the 1.6.0 upgrade. Build the promised minimal reproduction around py_test and py_library, then define what migration path or bounded fix would address incremental generation, import cycles, and conftest inclusion noted in issue #3497.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
build-system
Tipo de issue
Error
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.