bazel-contrib / bazel-contrib/rules_python

Custom platform from `pip.default` can't be used by consumers

Ouverte
#3,476 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Starlark
Étoiles
688
Forks
721
Merge moyen
15 h 7 min
PR mergées (30 j)
76

Description

# 🐞 bug report

## Affected Rule

The issue is caused by the bzlmod module extension pip in the pip.default / pip.parse tag handling in:

- python/private/pypi/extension.bzl (`build_config()`)
- python/private/pypi/parse_requirements.bzl (MacOS, `_package_srcs()`)
- python/private/pypi/hub_builder.bzl (Ubuntu, `_evaluate_markers()`)

### Is this a regression?

No.

### Description

When pip.default() is called from a non-root Bazel module (a dependency module), it is ignored while building the pip extension config. At the same time, pip.parse() in that dependency module is still processed and can create a hub repo that the consumer can use transitively.

This makes it impossible (or very confusing) for a dependency module to ship a reusable pip.parse() hub that relies on custom platforms defined by that same module’s pip.default().

#### Expected behavior

pip.default() platform definitions from a dependency module are applied at least for that module’s own pip.parse() tags.

#### Actual behavior

- pip.default() from dependency modules is ignored.
- pip.parse() from dependency modules is processed.
- If pip.parse() needs a custom platform, evaluation will fail with an error.
- Workaround today: the root module must re-declare the same platforms in its own pip.default().

## 🔬 Minimal Reproduction

Reproduction repository:

## 🔥 Exception or Error

- MacOS: `The target platform 'cp312.12_plat_a' could not be found in ["cp312.12_linux_x86_64", "cp312.12_linux_aarch64", "cp312.12_osx_aarch64", "cp312.12_osx_x86_64", "cp312.12_windows_x86_64", "cp312.12_windows_aarch64"]`
- Linux: `Error: key "cp312.12_plat_a" not found in dictionary`

## 🌍 Your Environment

### Operating System

```text
MacOS 26.1, Ubuntu 24.04
```

### Output of `bazel version`

```text
7.5.0
```

### Rules_python version

```text
1.7.0
```

### Anything else relevant

None.

## References

None.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Commencez par python/private/pypi/extension.bzl et la gestion de build_config(), puis suivez la logique associée dans parse_requirements.bzl (_package_srcs() pour MacOS) et hub_builder.bzl (_evaluate_markers() pour Ubuntu). Utilisez la reproduction minimale liée pour vérifier que les plateformes de pip.default() d’un module de dépendance s’appliquent à son hub pip.parse() sans que le module racine ait besoin de les redéclarer.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
python
Domaine
build-system
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.