bazel-contrib / bazel-contrib/rules_python

Support non-bash based script bootstrap

Offen
#3,012 0 Kommentare 2 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
core-rules Good first issue type: feature request
Vorherrschende Sprache
Starlark
Sterne
688
Forks
721
Ø Merge
15 Std. 7 Min.
Gemergte PRs (30 T.)
76

Beschreibung

Right now, the stage1 script bootstrap requires bash. It has a variety of bashisms or non-posix constructs that prevent it from working in other shells.

Bash isn't bad, it is just a heavier weight shell than e.g. dash (default on ubuntu/debian).

Looking at the code most changes are minor. The major change is the usage of arrays -- posix doesn't actually specify arrays.

Related: https://github.com/bazel-contrib/rules_python/issues/2500

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by locating the stage1 script bootstrap and reviewing its bash-specific constructs, especially the array usage. Test the bootstrap with dash, the non-bash shell called out in the issue, and confirm that it completes successfully without changing its existing behavior.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
bash, shell
Bereich
build-system
Issue-Typ
Feature
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
38/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.