bazel-contrib / bazel-contrib/rules_python

Runfiles API fails when code and output_user_root are on different Windows drives.

Offen
#2,141 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Starlark
Sterne
688
Forks
721
Ø Merge
15 Std. 7 Min.
Gemergte PRs (30 T.)
76

Beschreibung

# 🐞 bug report

### Affected Rule

`python.runfiles`

### Is this a regression?

I'm not sure, I've never seen it but I rarely use windows.

### Description

It seems if a repo is checked out to a different drive than the bazel output_base then the runfiles API breaks.

https://github.com/UebelAndre/rules_pytest/actions/runs/10495890608/job/29075336459

## 🔬 Minimal Reproduction

On https://github.com/UebelAndre/rules_pytest/tree/abb7f0e6598cb267a704e189237a14b5d777532d run:
```
bazel test //python/pytest/private/tests/version_test
```

## 🔥 Exception or Error

```
__________________________________________ test_versions __________________________________________
(19:07:33) INFO: Found 28 targets and 20 test targets...

def test_versions() -> None:
"""Test that the version.bzl and MOUDLE.bazel versions are synced."""
runfiles = Runfiles.Create()
if not runfiles:
raise EnvironmentError("Failed to locate runfiles.")

> version_bzl = rlocation(runfiles, "rules_pytest/version.bzl")

D:\a\rules_pytest\rules_pytest\python\pytest\private\tests\version_test\version_test.py:35:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
D:\a\rules_pytest\rules_pytest\python\pytest\private\tests\version_test\version_test.py:20: in rlocation
runfile = runfiles.Rlocation(rlocationpath)
..\rules_python\python\runfiles\runfiles.py:175: in Rlocation
source_repo = self.CurrentRepository(frame=2)
..\rules_python\python\runfiles\runfiles.py:248: in CurrentRepository
caller_runfiles_path = os.path.relpath(caller_path, self._python_runfiles_root)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

path = 'D:\\a\\rules_pytest\\rules_pytest\\python\\pytest\\private\\tests\\version_test\\version_test.py'
start = 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\Bazel.runfiles_ycjtfwtt\\runfiles'

> ???
E ValueError: path is on mount 'D:', start on mount 'C:'

:766: ValueError
```

## 🌍 Your Environment

**Operating System:**

  

windows

**Output of `bazel version`:**

  

Bazelisk version: 1.20.0
Build label: 7.3.1
Build target: @@//src/main/java/com/google/devtools/build/lib/bazel:BazelServer
Build time: Mon Aug 19 16:41:27 2024 (1724085687)
Build timestamp: 1724085687
Build timestamp as int: 1724085687

**Rules_python version:**

  

0.34.0

**Anything else relevant?**

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with python/runfiles/runfiles.py, especially Rlocation and CurrentRepository, then reproduce the failure using bazel test //python/pytest/private/tests/version_test on Windows with the repository and output root on different drives. The version_test.py traceback shows the failing path operation; done means the reproduction completes without the cross-drive ValueError and the behavior is covered by an appropriate test.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python
Bereich
build-system, tooling
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.