bazel-contrib / bazel-contrib/rules_python
Add Gazelle support for `importlib.import_module`?
- Lenguaje dominante
- Starlark
- Estrellas
- 688
- Forks
- 721
- Merge medio
- 15 h 7 min
- PR fusionados (30 d)
- 76
Descripción
# 🚀 feature request
### Relevant Rules
+ gazelle
### Description
First off, I want to say that I'm not sure if this is a good idea or not. So feel free to shoot it down 🤣.
In https://github.com/bazelbuild/rules_python/pull/1931#issuecomment-2141255218, it was said that the gazelle parser only needs to know about a subset of the python language:
> + comments
> + `if __name__ == "__main__"`
> + `from foo import bar`
> + `import foo`
However, there's another way to import other python code: [`importlib.import_module()`](https://docs.python.org/3/library/importlib.html#importlib.import_module).
**Should Gazelle parse these and attempt to add dependencies for them?**
#### Issues
There are a couple pretty big issues with trying to do so:
1. In my experience, `importlib.import_module` is typically used as a way to work around circular dependencies. So having Gazelle parse them would just result in a broken build, probably frustrating users more than helping.
2. There's no way to figure out what the runtime value would be.
+ So we could anything that's a string constant:
`import_module("foo.bar.baz")`
but not
`module = input("Enter a module name: "); import_module(module)` or even
`module = "foo.bar.baz"; import_module(module)`
#### Benefits
Umm... I guess if `import_module` is used in a _very specific_ way, then it would make making build files easier.
### Describe the solution you'd like
N/A
### Describe alternatives you've considered
Manually adding dependencies after running Gazelle. Not a big deal, IMO.
Guía de contribución
Línea de trabajo
Empieza por el analizador de Gazelle y la discusión de rules_python#1931 a la que hace referencia el issue. Evalúa las llamadas a importlib.import_module con cadenas constantes frente a las llamadas dinámicas en relación con las preocupaciones sobre dependencias circulares y, a continuación, establece el comportamiento esperado; se considerará terminado cuando la propuesta tenga un alcance decidido y una ruta de validación acordada.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- build-system
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100