bazel-contrib / bazel-contrib/rules_python

`pip.parse(python_version=)` should not be mandatory

Aperta
#1,708 10 commenti 1 reazione 0 assegnatari Vedi su GitHub
type: pip
Lingua principale
Starlark
Stelle
688
Fork
721
Merge medio
15h 7m
PR unite (30g)
76

Descrizione

# 🐞 bug report

### Affected Rule

Bzlmod `pip.parse()`

### Is this a regression?

Yes, was not a problem in WORKSPACE.

### Description

The arg documentation says the following:
https://github.com/bazelbuild/rules_python/blob/711186f144af06b431bd416b2d742874de3a2dea/python/private/bzlmod/pip.bzl#L391-L398

It specifically describes `If not specified, then the default Python version (as set by the root module or rules_python) will be used`. So this attribute should be optional but currently is mandatory.

## 🔬 Minimal Reproduction

`pip.parse()` without `python_version`.

## 🔥 Exception or Error

```
ERROR: in tag at /MODULE.bazel:42:10, mandatory attribute python_version isn't being specified
```

## 🌍 Your Environment

**Operating System:**

  

Linux

**Output of `bazel version`:**

  

2024/01/19 15:28:42 Warning: used fallback version "6.3.2"
Bazelisk version: v1.19.0
INFO: Running bazel wrapper (see //tools/bazel for details), bazel version 6.1.2 will be used instead of system-wide bazel installation.
Build label: 6.1.2
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Apr 18 15:29:54 2023 (1681831794)
Build timestamp: 1681831794
Build timestamp as int: 1681831794

**Rules_python version:**

  

0.27.1

**Anything else relevant?**

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Read python/private/bzlmod/pip.bzl around the documented python_version attribute at lines 391-398. Reproduce the minimal MODULE.bazel call using pip.parse() without python_version, then verify that the call succeeds and uses the documented default Python version.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
build-system
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
50/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.