baraja-core / baraja-core/simple-php-diff
Difference in last line does not get handled
- Lingua principale
- PHP
- Stelle
- 11
- Fork
- 2
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
### Bug Description
See title.
`getChangedLines()` does return the correct line numbers.
### Steps To Reproduce
Put a difference in the last line.
### Expected Behavior
The change in the last line should be displayed when calling `getDiff()` or `renderDiff()`.
### Possible Solution
`$captureLine` only gets pushed onto `$return` when a line is equal. When the last line is reached and differs, the for loop is already ending and the capture buffer is not checked anymore.
Seems to work when putting a copy of the `if ($captureBuffer !== [])` block before the `return`.
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inspect the implementation of getDiff() and renderDiff(), focusing on how the capture buffer is handled after the final line. Reproduce a difference on the last line and verify that the resulting diff includes it; the issue is done when both methods display that final-line change.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- php
- Ambito
- backend
- Tipo di issue
- Bug
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 45/100