awslabs / awslabs/rds-data-api-client-library-java

Collection of DTOs as input parameters

未关闭
#11 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Java
星标
21
派生
5
PR 合并指标
30 天内没有已合并 PR

描述

Hi Team,

The library supports var args to pass multiple objects:
```
var account1 = new Account(1, "John");
var account2 = new Account(2, "Mary");
client.forSql("INSERT INTO accounts(accountId, name) VALUES(:accountId, :name)")
.withParamSets(account1, account2)
.execute();
```

If we need to pass Collection we have to call toArray():
```
List accounts = List.of(new Account(1, "John"), new Account(2, "Mary")....);
client.forSql("INSERT INTO accounts(accountId, name) VALUES(:accountId, :name)")
.withParamSets(accounts.toArray())
.execute();
```

Batch saving quite often is used with a list of objects and it would help to avoid extra call toArray().

Could you please add overloaded withParamSets method or a new method to pass java.util.Collection, for instance:
```
List accounts = List.of(new Account(1, "John"), new Account(2, "Mary")....);
client.forSql("INSERT INTO accounts(accountId, name) VALUES(:accountId, :name)")
.withParamCollection(accounts)
.execute();
```

Thank you.

贡献指南

打开贡献指南

调研方向

首先定位 withParamSets 入口点及其现有的 varargs 处理方式。检查其调用方和测试,然后在保留当前 varargs 行为的同时支持 java.util.Collection 输入;当可以直接传入 collection 进行批量执行时,即视为完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
database
Issue 类型
功能
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。