aws / aws/serverless-java-container

Increase test coverage for servlet specification compliance

Open
#1,278 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.6k
Forks
574
PR merge metrics
No merged PRs in 30d

Description

Currently there are two ways of mapping request events to servlet requests. The classic way is covered by tests using `com.amazonaws.serverless.proxy.internal.testutils.AwsProxyRequestBuilder`, the new way using Spring Cloud is tested in `com.amazonaws.serverless.proxy.spring.AwsSpringHttpProcessingUtilsTests`. The latter doesn't cover all cases that were already implemented in previous years, so we'd need to transfer the tests.

Ideally we'd leverage the official TCK https://github.com/jakartaee/servlet/tree/master/tck to some extend.

Contributor guide

Open the contributing guide

Research direction

Compare the cases covered through com.amazonaws.serverless.proxy.internal.testutils.AwsProxyRequestBuilder with com.amazonaws.serverless.proxy.spring.AwsSpringHttpProcessingUtilsTests. Start by running the Spring Cloud servlet-processing tests and identify implemented cases missing there. Transfer the relevant coverage, then assess whether the Jakarta Servlet TCK can add useful compliance checks; done means the new mapping path covers the prior cases and tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.