aws / aws/sagemaker-python-sdk
sagemaker-train should depend on mlflow-skinny, following sagemaker-mlflow 0.5.0
- Langage dominant
- Python
- Étoiles
- 2.3k
- Forks
- 1.3k
- Merge moyen
- 1 j 22 h
- PR mergées (30 j)
- 35
Description
## Describe the feature you'd like
`sagemaker-train` (and `sagemaker-serve`) declare an unconditional dependency on the full `mlflow` distribution:
```
sagemaker-train 1.18.0: mlflow<4.0.0,>=3.0.0
```
The training integration uses MLflow purely as a tracking client (logging runs and metrics to a configured tracking server), which `mlflow-skinny` implements completely. The full distribution additionally drags in the tracking server stack and its dependency constraints.
`sagemaker-mlflow` already made exactly this change in 0.5.0: `mlflow-skinny>=2.8` as the base requirement, with full mlflow relegated to an optional `full` extra. Applying the same pattern to `sagemaker-train` and `sagemaker-serve` would make the SDK family consistent.
## Why it matters
Full mlflow currently caps `cryptography<50`. Snyk advisories SNYK-PYTHON-CRYPTOGRAPHY-18516620/21/22 (two high severity) are fixed only in cryptography 50.0.0, so any project consuming sagemaker-train transitively cannot reach the fixed version and must either waive the findings or remove sagemaker-train. Since the mlflow usage is client-only, the cap buys nothing for these packages.
## Suggested change
Mirror sagemaker-mlflow 0.5.0: depend on `mlflow-skinny`, offer full mlflow behind an extra for anyone who genuinely needs the server components.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Inspectez les métadonnées de dépendances de sagemaker-train et sagemaker-serve, puis comparez-les au modèle sagemaker-mlflow 0.5.0 décrit dans l’issue. Vérifiez que mlflow-skinny est l’exigence de base, que mlflow complet est disponible via un extra optionnel et que la résolution des dépendances n’impose plus la limite supérieure de cryptography signalée.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- aws, python
- Domaine
- build-system, machine-learning
- Type d'issue
- Fonctionnalité
- Difficulté
- 2/5
- Temps estimé
- Une demi-journée
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 72/100