aws / aws/sagemaker-python-sdk

ModelTrainer (V3) does not support output_kms_key for source code uploads

Aperta
#5,956 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
2.3k
Fork
1.3k
Merge medio
1g 22h
PR unite (30g)
35

Descrizione

## Describe the bug

In SageMaker SDK V2, the `Estimator` uses the `output_kms_key` when uploading user training scripts to S3 (see `_stage_user_code_in_s3`):
https://github.com/aws/sagemaker-python-sdk/blob/5b3b127a2d3d12a6ff0d877ddfd9ddf13527c27f/src/sagemaker/estimator.py#L1044-L1108

In SageMaker SDK V3, the new `ModelTrainer` does not apply any KMS key when uploading source code while creating the input data channel:
https://github.com/aws/sagemaker-python-sdk/blob/9101cef1a589cf2b44e73c5456dfa46c10e32691/sagemaker-train/src/sagemaker/train/model_trainer.py#L834-L953

Additionally, even when providing an S3 URI in the `SourceCode` object (instead of a local path), the `ModelTrainer` still uploads additional driver files whenever source code is specified:
https://github.com/aws/sagemaker-python-sdk/blob/9101cef1a589cf2b44e73c5456dfa46c10e32691/sagemaker-train/src/sagemaker/train/model_trainer.py#L684-L689

These uploads do not use a KMS key.

## Expected behavior

`ModelTrainer` should:
- either respect a user-provided KMS key (similar to `output_kms_key` in V2), OR
- allow configuration of a KMS key for all S3 uploads related to source code.

## Actual behavior

- Source code and driver files are uploaded to S3 without KMS encryption.
- There is no apparent way to configure a KMS key for these uploads.

## Impact

In restricted environments (like ours), S3 policies enforce server-side encryption with KMS.
As a result, `ModelTrainer` cannot be used with custom training scripts.

This blocks use cases that rely on custom code, such as MLflow serverless integration.

## Steps to reproduce

1. Create a `ModelTrainer` with a `SourceCode` object
2. Provide either:
- a local path, or
- an S3 URI
3. Observe that S3 uploads occur without KMS encryption

## Possible solution

Expose a parameter similar to `output_kms_key` in V2, or reuse existing encryption configuration mechanisms.

## Additional context

This is a regression compared to V2 `Estimator` behavior and impacts secure environments with strict S3 encryption policies.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia in sagemaker-train/src/sagemaker/train/model_trainer.py, nei percorsi di upload dell’input-channel e del driver-file citati nell’issue, quindi confrontali con _stage_user_code_in_s3 in src/sagemaker/estimator.py. Traccia la configurazione di crittografia esistente e aggiungi una copertura mirata per gli upload di SourceCode locali e S3. Il lavoro è completato quando tutti gli upload relativi al codice sorgente possono usare la chiave KMS configurata.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
aws, python
Ambito
cloud, machine-learning
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
68/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.