aws / aws/sagemaker-python-sdk

Make all Pipeline Parameters hashable

Offen
#4,601 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @mollyheamazon Auf GitHub ansehen
component: pipelines type: feature request
Vorherrschende Sprache
Python
Sterne
2.3k
Forks
1.3k
Ø Merge
1 T. 22 Std.
Gemergte PRs (30 T.)
35

Beschreibung

**Describe the feature you'd like**

Certain operations in Python require hashable objects. While `sagemaker.workflow.parameters.ParameterString` is hashable, other data types such as `ParameterInteger`, `ParameterBoolean` or `ParameterFloat` are not hashable. To me, it's unclear why only string parameters should be washable, as the underlaying method `__hash__(self)` could apparently easily be implemented at the `sagemaker.workflow.parameters.Parameter` instead at `sagemaker.workflow.parameters.ParameterString`. Currently, it's implemented like this:

```python
class ParameterString(Parameter):
# ...
def __hash__(self):
"""Hash function for parameter types"""
return hash(tuple(self.to_request()))

```

**How would this feature be used? Please describe.**

Use non-string parameters in places where a hashable object is required, e.g. dict keys.

**Describe alternatives you've considered**

Use `ParameterString` everywhere, even when the underlaying data type is not actually a string.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.