aws / aws/sagemaker-python-sdk

Use samekaer_session (LocalSession) in utils.py

Aperta
#3,189 0 commenti 0 reazioni 1 assegnatario Rivendicata da @mollyheamazon Vedi su GitHub
type: feature request type: maintenance
Lingua principale
Python
Stelle
2.3k
Fork
1.3k
Merge medio
1g 22h
PR unite (30g)
35

Descrizione

Hello,

You give the ability to use LocalSession which is potentially really helpful. I am still struggling to make it work by using local-stack and pytests.

I find everywhere small obstacles from the code, Eg. here in utils you are recreating resources (eg s3) instead of using the s3 resource of the `sagemaker_session` which a user can initialize it with local `s3_url_endpoint`
https://github.com/aws/sagemaker-python-sdk/blob/72c12bb1481c368f799b17c38d07c5fc34864093/src/sagemaker/utils.py#L532

So instead of doing this
```
boto_session = sagemaker_session.boto_session
s3 = boto_session.resource("s3", region_name=boto_session.region_name)
```
you could simple do this if `s3_resource` is initialized
```
s3 = sagemaker_session.s3_resource
```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.