aws / aws/sagemaker-python-sdk

Use samekaer_session (LocalSession) in utils.py

Open
#3,189 0 comments 0 reactions 1 assignee Claimed by @mollyheamazon View on GitHub
type: feature request type: maintenance
Dominant language
Python
Stars
2.3k
Forks
1.3k
Avg merge
2d 2h
Merged PRs (30d)
32

Description

Hello,

You give the ability to use LocalSession which is potentially really helpful. I am still struggling to make it work by using local-stack and pytests.

I find everywhere small obstacles from the code, Eg. here in utils you are recreating resources (eg s3) instead of using the s3 resource of the `sagemaker_session` which a user can initialize it with local `s3_url_endpoint`
https://github.com/aws/sagemaker-python-sdk/blob/72c12bb1481c368f799b17c38d07c5fc34864093/src/sagemaker/utils.py#L532

So instead of doing this
```
boto_session = sagemaker_session.boto_session
s3 = boto_session.resource("s3", region_name=boto_session.region_name)
```
you could simple do this if `s3_resource` is initialized
```
s3 = sagemaker_session.s3_resource
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.