aws / aws/aws-xray-sdk-java

Remove support for non-streaming subsegments

Aperta
#280 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
Java
Stelle
100
Fork
100
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

There is currently a huge amount of complexity and some performance overhead due to the ability to optionally stream or not stream subsegments - it continues to cause thread safety issues and is very fragile code. Simpler would be to just have `Entity.end()` immediately send an entity without keeping track of the whole segment.

As the OpenTelemetry integrations with X-Ray do not do the segment batching, I think we can consider that a baseline and remove our support for non-streaming from here too.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by tracing Entity.end() and the code paths that support optionally streaming subsegments. Compare the behavior with the OpenTelemetry X-Ray integrations mentioned in the issue. Done means non-streaming subsegment support and its associated complexity are removed while segment and entity sending behavior remains consistent.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
backend, observability-sre
Tipo di issue
Refactoring
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.