aws / aws/aws-xray-sdk-java

Support custom matching attributes in CentralizedRule

Ouverte
#116 3 commentaires 0 réactions 1 personne assignée Réclamée par @wangzlei Voir sur GitHub
enhancement
Langage dominant
Java
Étoiles
100
Forks
100
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Java SDK: `com.amazonaws:aws-xray-recorder-sdk-aws-sdk-v2:2.4.0`

I just spent a good amount of time figuring out why the SDK told me that my sampling rule (created in the official AWS console) is "invalid".

Turns out it is because custom attribute matching is not supported, see https://github.com/aws/aws-xray-sdk-java/blob/126b60ea543509f9cd6510b5dff833947d826d78/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/rule/CentralizedRule.java#L105.

It would be really nice if this was supported, but if not at least the error message should be more helpful. This is an official feature as it is available in the X-Ray console, so it's a bit weird to get told that the rule created with the official tools is invalid.

In this case I wanted to limit X-Ray sampling from one specific IP.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.