DynamoDB enhanced client DynamoDbIndex.query to return PageIterable
- Lenguaje dominante
- Java
- Estrellas
- 2.6k
- Forks
- 1k
- Merge medio
- 2 d 9 h
- PR fusionados (30 d)
- 51
Descripción
### Describe the feature
When using enhanced DynamoDB there is an interface for PageIterable that adds useful functionality on top of SDKIterable.java, namely an iterator across all pages from the result set. The [query method](https://github.com/aws/aws-sdk-java-v2/blob/8f54393ff4e166eb3f56bc1b411b27f6bf0213b5/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/client/DefaultDynamoDbIndex.java#L57) of DynamoDBTable.java returns said useful type, however similar class DynamoDBIndex.java returns the more basic SDKIterable.java in the [query method](https://github.com/aws/aws-sdk-java-v2/blob/8f54393ff4e166eb3f56bc1b411b27f6bf0213b5/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/client/DefaultDynamoDbTable.java#L177).
This was already raised in https://github.com/aws/aws-sdk-java-v2/issues/2185, but I believe the documentation fix is not the ideal long term solution. The solution would be to provide similar support for query() both in DynamoDBTable and DynamoDBIndex.
When using dynamo console in the browser, the query works the same for the default table index and the created GSIs, the code should behave consistently.
### Is your Feature Request related to a problem?
This requires all consumers of SDK to do extra coding for replicating code that the SDK already distributes. This increases code duplication as is error prone, both issues that PageIterable interface solves in the first place.
### Proposed Solution
Proposal for non-breaking change,
- Keep the existing DynamoDBIndex ```SdkIterable> query(QueryEnhancedRequest request);```
- Add a new method in DynamoDBIndex ```PageIterable query(QueryEnhancedRequest request);```
### Describe alternatives you've considered
_No response_
### Acknowledge
- [ ] I may be able to implement this feature request
### AWS Java SDK version used
2.17.76
### JDK version used
openjdk 11.0.12
### Operating System and version
MacOS 12.0.1
Guía de contribución
Línea de trabajo
Comienza con las declaraciones de consulta de DynamoDBIndex y DynamoDBTable y, a continuación, compara DefaultDynamoDbIndex.java con DefaultDynamoDbTable.java, especialmente las implementaciones de consulta relacionadas. Traza cómo se devuelve PageIterable para las consultas de tabla y determina el comportamiento correspondiente del índice; se considera terminado cuando las consultas de índice proporcionan la misma compatibilidad para la iteración de páginas, manteniendo al mismo tiempo los requisitos de compatibilidad propuestos.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- aws, java
- Área
- database
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 35/100