DefaultStringConverterProvider can't convert Map with Enum as a key
- Lenguaje dominante
- Java
- Estrellas
- 2.6k
- Forks
- 1k
- Merge medio
- 2 d 9 h
- PR fusionados (30 d)
- 51
Descripción
Mapping of the `Map` where `K` is enum doesn't work.
Example entity:
```
@DynamoDbBean
@Data
public class TestClass {
@DynamoDbPartitionKey
private String id;
private Map map;
public enum Status {
ONE, TWO
}
}
```
Example `TableSchema`
```
private TableSchema tableSchema = TableSchema.fromBean(TestClass.class);
```
## Describe the bug
Mapping doesn't work.
## Expected Behavior
Mapping works.
## Current Behavior
It fails with the following error:
```
Caused by: java.lang.IllegalArgumentException: No string converter exists for class test.TestClass.Status
```
Full stacktrace:
```
Caused by: java.lang.IllegalArgumentException: No string converter exists for class test.TestClass.Status
at software.amazon.awssdk.enhanced.dynamodb.internal.converter.string.DefaultStringConverterProvider.converterFor(DefaultStringConverterProvider.java:155)
at software.amazon.awssdk.enhanced.dynamodb.DefaultAttributeConverterProvider.createMapConverter(DefaultAttributeConverterProvider.java:182)
at software.amazon.awssdk.enhanced.dynamodb.DefaultAttributeConverterProvider.findConverter(DefaultAttributeConverterProvider.java:149)
at software.amazon.awssdk.enhanced.dynamodb.DefaultAttributeConverterProvider.converterFor(DefaultAttributeConverterProvider.java:133)
at software.amazon.awssdk.enhanced.dynamodb.mapper.ImmutableAttribute.converterFrom(ImmutableAttribute.java:167)
at software.amazon.awssdk.enhanced.dynamodb.mapper.ImmutableAttribute.resolve(ImmutableAttribute.java:163)
at software.amazon.awssdk.enhanced.dynamodb.mapper.StaticImmutableTableSchema.lambda$new$0(StaticImmutableTableSchema.java:153)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1624)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at java.base/java.util.stream.StreamSpliterators$WrappingSpliterator.forEachRemaining(StreamSpliterators.java:312)
at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:734)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
at software.amazon.awssdk.enhanced.dynamodb.mapper.StaticImmutableTableSchema.(StaticImmutableTableSchema.java:159)
at software.amazon.awssdk.enhanced.dynamodb.mapper.StaticImmutableTableSchema.(StaticImmutableTableSchema.java:77)
at software.amazon.awssdk.enhanced.dynamodb.mapper.StaticImmutableTableSchema$Builder.build(StaticImmutableTableSchema.java:425)
at software.amazon.awssdk.enhanced.dynamodb.mapper.StaticTableSchema.(StaticTableSchema.java:66)
at software.amazon.awssdk.enhanced.dynamodb.mapper.StaticTableSchema.(StaticTableSchema.java:64)
at software.amazon.awssdk.enhanced.dynamodb.mapper.StaticTableSchema$Builder.build(StaticTableSchema.java:255)
at software.amazon.awssdk.enhanced.dynamodb.mapper.BeanTableSchema.createStaticTableSchema(BeanTableSchema.java:200)
at software.amazon.awssdk.enhanced.dynamodb.mapper.BeanTableSchema.create(BeanTableSchema.java:124)
at software.amazon.awssdk.enhanced.dynamodb.mapper.BeanTableSchema.create(BeanTableSchema.java:116)
at software.amazon.awssdk.enhanced.dynamodb.TableSchema.fromBean(TableSchema.java:80)
at test.DynamoDbTestConfiguration.(DynamoDbTestConfiguration.java:22)
at test.DynamoDbTestConfiguration$$EnhancerBySpringCGLIB$$9f051cd1.()
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:204)
... 111 more
```
If I swap Map key and value:
```
@DynamoDbBean
@Data
public class TestClass {
@DynamoDbPartitionKey
private String id;
private Map map;
public enum Status {
ONE, TWO
}
}
```
it works!
## Steps to Reproduce
Follow the steps above.
## Possible Solution
Support Enum as a key in a `Map`.
## Context
I am trying to save a map with enum as key.
## Your Environment
* AWS Java SDK version used: `2.15.2`
* JDK version used: `14`
* Operating System and version: `MacOS 10.15.7`
Related to the comment https://github.com/aws/aws-sdk-java-v2/issues/35#issuecomment-606159193
Guía de contribución
Línea de trabajo
Comienza con DefaultStringConverterProvider.java:155 y DefaultAttributeConverterProvider.java:133-182, y luego reproduce el fallo usando TableSchema.fromBean(TestClass.class) con Map. Compáralo con el caso funcional Map; se considera terminado cuando un bean que contiene un mapa con claves enum puede mapearse sin la IllegalArgumentException indicada.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java
- Área
- databases
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 38/100