aws / aws/aws-node-termination-handler
Add custom delay for instance refresh actions
- Lenguaje dominante
- Go
- Estrellas
- 1.8k
- Forks
- 286
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
When using instance refresh to update ASGs it looks like the events come through with a start date of now which triggers the node-termination handler to start cordoning and draining the node immediately. This does work correctly if the ASG healthy percentage is set to 100% and all pods have replicas and PDBs (for NTH we need https://github.com/aws/aws-node-termination-handler/pull/463 to satisfy this); but single pods such as Prometheus will often be un-schedulable for a short period while the new node boots up.
To make this whole process function without any downtime a custom duration to wait on ASG termination events could be adopted and defaulted to something like 90 seconds. Assuming that this wait time was longer than the time to start and join a node to the cluster there would be no un-schedulable pods and the ability to use a non 100% ASG healthy percentage. Combined with the ASG lifecycle hook timeout this would support a high level of customisation without much extra complexity.
Guía de contribución
Línea de trabajo
Empieza por rastrear cómo los eventos de terminación de ASG de un instance refresh llegan al node-termination handler y dónde comienzan el cordoning y el draining. Define cómo interactúa una espera configurable con el tiempo de espera del lifecycle hook de ASG, establécela de forma predeterminada en unos 90 segundos y verifica que los pods sigan siendo schedulable mientras los nodos de reemplazo se inician y se unen al clúster.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- aws, go, kubernetes
- Área
- cloud, devops
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100