aws / aws/aws-lambda-java-libs

DynamodbAttributeValueTransformer causing break in functionality for empty list when transforming (v2)

未關閉
#224 2 則留言 2 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Java
星號
548
分支
241
平均合併
2 天 5 分鐘
30 天內合併 PR
11

描述

I'm using DynamoDb Enhanced library version `2.15.82`. Recently, `aws-lambda-java-events-sdk-transformer` version `3.0.2` causes a break in the functionality when trying to transform empty list. Empty list is transformed to `null` which for DynamoDb Enhanced library expects an empty list, and causes DynamoDB Enhanced library to throw the below stack trace.

```
java.lang.IllegalStateException: Unable to convert attribute value: AttributeValue()
software.amazon.awssdk.enhanced.dynamodb.internal.converter.attribute.EnhancedAttributeValue.fromAttributeValue(EnhancedAttributeValue.java:352) ~[dynamodb-enhanced-2.15.82.jar:na]
software.amazon.awssdk.enhanced.dynamodb.internal.converter.attribute.ListAttributeConverter$Delegate.transformTo(ListAttributeConverter.java:154) ~[dynamodb-enhanced-2.15.82.jar:na]
software.amazon.awssdk.enhanced.dynamodb.internal.converter.attribute.ListAttributeConverter.transformTo(ListAttributeConverter.java:120) ~[dynamodb-enhanced-2.15.82.jar:na]
software.amazon.awssdk.enhanced.dynamodb.internal.converter.attribute.ListAttributeConverter.transformTo(ListAttributeConverter.java:82) ~[dynamodb-enhanced-2.15.82.jar:na]
software.amazon.awssdk.enhanced.dynamodb.internal.mapper.StaticAttributeType.attributeValueToObject(StaticAttributeType.java:44) ~[dynamodb-enhanced-2.15.82.jar:na]
software.amazon.awssdk.enhanced.dynamodb.internal.mapper.ResolvedImmutableAttribute.lambda$create$1(ResolvedImmutableAttribute.java:61) ~[dynamodb-enhanced-2.15.82.jar:na]
software.amazon.awssdk.enhanced.dynamodb.mapper.StaticImmutableTableSchema.mapToItem(StaticImmutableTableSchema.java:458) ~[dynamodb-enhanced-2.15.82.jar:na]
software.amazon.awssdk.enhanced.dynamodb.mapper.WrappedTableSchema.mapToItem(WrappedTableSchema.java:54) ~[dynamodb-enhanced-2.15.82.jar:na]
```

Further investigation points to the below code in `DynamodbAttributeValueTransformer` that's causing the issue
```
else if (Objects.nonNull(value.getL())) {
return AttributeValue.builder()
.l(value.getL().isEmpty()
? null
: value.getL().stream()
.map(DynamodbAttributeValueTransformer::toAttributeValueV2)
.collect(Collectors.toList()))
.build();

}
```

I noticed this change happens from `aws-lambda-java-events-sdk-transformer` version `2.0.8` to `3.0.0` on commit `3e71a17c57ba6c99734c4633a4f412fd2d5b6b42`

Any advice on this? Is there a reason for this code change that causes a break in functionality?

貢獻指南

開啟貢獻指南

研究方向

從 DynamodbAttributeValueTransformer 開始,比較 2.0.8 與 3.0.0 版本之間引入的空清單處理方式,尤其是 commit 3e71a17c57ba6c99734c4633a4f412fd2d5b6b42。使用 aws-lambda-java-events-sdk-transformer 3.0.2 和 DynamoDb Enhanced 2.15.82 重現該轉換;當空清單不再變成 null 或導致所示的轉換失敗時,即表示完成。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
java
領域
backend
Issue 類型
缺陷
難度
2/5
預估耗時
1-3 小時
活躍度
停滯
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。