aws / aws/aws-lambda-go

Mismatched CodePipeline CloudWatch fields

Aperta
#421 1 commento 1 reazione 0 assegnatari Vedi su GitHub
bug type/events
Lingua principale
Go
Stelle
3.8k
Fork
578
Merge medio
8h 18m
PR unite (30g)
1

Descrizione

Hi all, thanks for your support on this library. I was recently trying to replace our homemade structs for CodePipeline events with the ones defined in this package but I'm running into the following errors unmarshalling the `version` fields in `CodePipelineEventDetail` and `CodePipelineEventDetail`:

```Go
json: cannot unmarshal number 2.0 into Go struct field CodePipelineEventDetail.detail.version of type int64: errorString null

json: cannot unmarshal string into Go struct field CodePipelineEventDetailType.detail.type.version of type int64: errorString null
```

The unmarshalling works when `CodePipelineEventDetail.detail.version` is a `float64` and `CodePipelineEventDetailType.detail.type.version` is a string (using our own structs). Would y'all mind taking another look at the types for the two `versions` fields?

Based on the comments for each of them, it sounds like there's some mismatch in the schema/documentation:
https://github.com/aws/aws-lambda-go/blob/96ab249f3eb7644ebc3bb7a190d268184fdd9f4e/events/codepipeline_cloudwatch.go#L82-L83

https://github.com/aws/aws-lambda-go/blob/96ab249f3eb7644ebc3bb7a190d268184fdd9f4e/events/codepipeline_cloudwatch.go#L105-L106

Thanks!

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start in events/codepipeline_cloudwatch.go at the referenced lines for the CodePipelineEventDetail and CodePipelineEventDetailType version fields. Compare those declarations with the reported JSON unmarshalling errors and the comments, then confirm that representative numeric and string version values decode successfully with the corrected types.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
go
Ambito
backend
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.