aws / aws/aws-lambda-dotnet

Amazon.Lambda.Core is not deterministic

Aperta
#2,181 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
feature-request module/lambda-client-lib p2 queued
Lingua principale
C#
Stelle
1.7k
Fork
503
Merge medio
1g 5h
PR unite (30g)
18

Descrizione

### Describe the bug

Viewing [Amazon.Lambda.Core 2.8.0 in NuGet Package Explorer](https://nuget.info/packages/Amazon.Lambda.Core/2.8.0) shows various warnings about the build of the package with respect to Source Link and determinism:

Image

The NuGet packages should be built with `ContinuousIntegrationBuild=true` and `Deterministic=true` to resolve this.

.NET global tools such as `dotnet-validate` and `meziantou.framework.nugetpackagevalidation.tool` can be used to verify this.

For Amazon.Lambda.Core at least, this doesn't appear to be a regression and these have never been enabled.

### Regression Issue

- [ ] Select this option if this issue appears to be a regression.

### Expected Behavior

Packages should be deterministic, e.g. [OpenTelemetry.Instrumentation.AWSLambda@1.13.0](https://nuget.info/packages/OpenTelemetry.Instrumentation.AWSLambda/1.13.0):

Image

### Current Behavior

NuGet package is not deterministic:

Image

### Reproduction Steps

View the NuGet package in [NuGet Package Explorer](https://nuget.info/packages/Amazon.Lambda.Core/2.8.0).

### Possible Solution

Set `ContinuousIntegrationBuild=true` and `Deterministic=true` MSBuild properties when building the NuGet packages for publishing to NuGet.org.

### Additional Information/Context

_No response_

### AWS .NET SDK and/or Package version used

Amazon.Lambda.Core 2.8.0

### Targeted .NET Platform

All

### Operating System and version

All

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

L’issue non indica alcun file sorgente né alcun test; inizia individuando la configurazione di build utilizzata per pubblicare Amazon.Lambda.Core 2.8.0. Valida un pacchetto compilato con dotnet-validate o meziantou.framework.nugetpackagevalidation.tool e considera concluso il lavoro quando il pacchetto segnala la conformità a ContinuousIntegrationBuild e Deterministic.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
csharp
Ambito
build-system
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.