aws / aws/aws-lambda-dotnet

Support IDisposable for Function Handlers

Abierto
#2,159 2 comentarios 1 reacción 0 asignados Ver en GitHub
feature-request module/lambda-client-lib needs-investigation p2
Lenguaje dominante
C#
Estrellas
1.7k
Forks
503
Merge medio
1 d 18 h
PR fusionados (30 d)
21

Descripción

### Describe the feature

It's the same feature request as https://github.com/aws/aws-lambda-dotnet/issues/342 - to dispose function handler when Lambda service deletes the execution environment.

It was closed because there was no hook from lambda service at that time. But now there is - Lambda sends SIGTERM to runtime before reclaiming the environment.

### Use Case

Any features which requires some cleanup.
Flushing logs and traces, closing DB connections, etc.

### Proposed Solution

I have implemented it for my handlers via smth like that:
```csharp
public abstract class AbstractLambdaHandler : IDisposable
{
private readonly PosixSignalRegistration sigTermRegistration;

protected AbstractLambdaHandler()
{
// AWS Lambda service sends SIGTERM signal before killing lambda container, but
// lambda-dotnet runtime does not handle it yet - https://github.com/aws/aws-lambda-dotnet/issues/342 .
// Until it is implemented, we use custom signal registration to dispose lambda handler.
sigTermRegistration = PosixSignalRegistration.Create(PosixSignal.SIGTERM, _ =>
{
Logger?.LogDebug("SIGTERM signal received. Disposing Lambda Handler.");
Dispose();
});
}

public virtual void Dispose()
{
sigTermRegistration?.Dispose();
// Dispose other things.
}
}
```

It would be nice to have it provided by the runtime itself though.

### Other Information

_No response_

### Acknowledgements

- [x] I may be able to implement this feature request
- [ ] This feature might incur a breaking change

### AWS .NET SDK and/or Package version used

Amazon.Lambda.Core 2.7.1

### Targeted .NET Platform

.NET 8

### Operating System and version

AmazonLinux

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza revisando el comportamiento del handler de Amazon.Lambda.Core 2.7.1 y el ciclo de vida de SIGTERM descrito en este issue; después, compáralo con el issue 342 anterior. Se considera terminado cuando el runtime proporciona una forma definida de hacer dispose de los function handlers cuando Lambda envía SIGTERM, incluida la limpieza, como vaciar los logs o cerrar las conexiones.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
aws, csharp
Área
backend, cloud
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.