aws / aws/aws-encryption-sdk-python

Logging an exception instead of / and a `raise` pollutes the log with extra traceback.

Open
#615 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
255
Forks
92
Avg merge
2d 17h
Merged PRs (30d)
2

Description

### Problem:

In many places in the SDK codebase, there are exception logging using the `_LOGGER.exception`. This logs the traceback of the exception. The encountered exception might then be bubbled up to the caller, or to the exit call which then again logs this exception. This causes duplicate logging at best, and confusion at worst since the exception message/type can be different.

### Solution:

Clean up the logging, and use raise over logging the exception wherever possible.

Ref https://github.com/aws/aws-encryption-sdk-python/issues/566

[//]: # (NOTE: If you believe this might be a security issue, please email aws-security@amazon.com instead of creating a GitHub issue. For more details, see the AWS Vulnerability Reporting Guide: https://aws.amazon.com/security/vulnerability-reporting/ )

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.