aws / aws/aws-dynamodb-encryption-python

Wrong formatting in the deprecated python warning

Open
#524 3 comments 0 reactions 0 assignees View on GitHub
good first issue maintenance
Dominant language
Python
Stars
95
Forks
57
PR merge metrics
No merged PRs in 30d

Description

### Security issue notifications

If you discover a potential security issue in the Amazon DynamoDB Encryption Client we ask that you notify AWS Security via our [vulnerability reporting page](https://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public GitHub issue.

### Problem:
https://github.com/aws/aws-dynamodb-encryption-python/blob/35ee30aea5a93b4446677fdf1f14edc3ca3c0452/src/dynamodb_encryption_sdk/compatability.py#L39

The _minimum_version_ and _date_ seem to have been swapped in the deprecated python warning.
### Solution:

Putting the `params["date"]` before the `minimum_version[0]` should fix the issue.

### Out of scope:

Is there anything the solution will intentionally NOT address?

[//]: # (NOTE: If you believe this might be a security issue, please email aws-security@amazon.com instead of creating a GitHub issue. For more details, see the AWS Vulnerability Reporting Guide: https://aws.amazon.com/security/vulnerability-reporting/ )

Contributor guide

Open the contributing guide

Research direction

Open src/dynamodb_encryption_sdk/compatability.py at line 39 and inspect the deprecated Python warning formatting. Verify which values are currently used for the minimum version and date, then confirm the warning presents them in the intended order described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.