aws / aws/aws-dynamodb-encryption-python

Wrong formatting in the deprecated python warning

Open
#524 3 comments 0 reactions 0 assignees View on GitHub
good first issue maintenance
Dominant language
Python
Stars
95
Forks
57
PR merge metrics
No merged PRs in 30d

Description

### Security issue notifications

If you discover a potential security issue in the Amazon DynamoDB Encryption Client we ask that you notify AWS Security via our [vulnerability reporting page](https://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public GitHub issue.

### Problem:
https://github.com/aws/aws-dynamodb-encryption-python/blob/35ee30aea5a93b4446677fdf1f14edc3ca3c0452/src/dynamodb_encryption_sdk/compatability.py#L39

The _minimum_version_ and _date_ seem to have been swapped in the deprecated python warning.
### Solution:

Putting the `params["date"]` before the `minimum_version[0]` should fix the issue.

### Out of scope:

Is there anything the solution will intentionally NOT address?

[//]: # (NOTE: If you believe this might be a security issue, please email aws-security@amazon.com instead of creating a GitHub issue. For more details, see the AWS Vulnerability Reporting Guide: https://aws.amazon.com/security/vulnerability-reporting/ )

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.