aws / aws/aws-dynamodb-encryption-java

Don't print AttributeValues in EncryptionContext.toString()

Open
#100 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
141
Forks
74
PR merge metrics
No merged PRs in 30d

Description

https://github.com/aws/aws-dynamodb-encryption-java/blob/master/sdk1/src/main/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/EncryptionContext.java#L220

https://github.com/aws/aws-dynamodb-encryption-java/blob/master/sdk2/src/main/java/software/amazon/cryptools/dynamodbencryptionclientsdk2/encryption/EncryptionContext.java#L182

A safe `toString()` method for `EncryptionContext` would be extremely useful for logging within material providers, and we can get there by excluding attributeValues from being printed. Since it is likely that tests rely on this today, we should consider doing this with a minor bump. (Note: We haven't published the sdk2 version yet, so it's not necessary to do a bump there.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.