aws / aws/aws-durable-execution-sdk-python

[Bug]: Virtual child replay can consume a non-virtual container checkpoint

Abierto
#704 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug pkg:sdk
Lenguaje dominante
Python
Estrellas
53
Forks
25
Merge medio
1 d 19 h
PR fusionados (30 d)
40

Descripción

## Expected Behavior

When replay changes a `run_in_child_context` operation from non-virtual to `ChildConfig(is_virtual=True)`, the SDK should reject the existing container checkpoint with `NonDeterministicExecutionError` before returning its cached result or emitting replay hooks.

Virtual child contexts never write their own container checkpoint. Therefore, any existing checkpoint at the virtual child operation ID proves that the prior execution used non-virtual checkpointing.

## Actual Behavior

`is_virtual` is not represented in `OperationIdentifier`. A successful `CONTEXT` checkpoint from a previous non-virtual child passes type, subtype, name, and parent validation. `ChildOperationExecutor.check_result_status()` then returns the cached result without executing the current virtual child body, so changes to the inner hierarchy are never validated.

This reproduces on both `main` and PR #698, so it is pre-existing and separate from #692, whose scope is type/subtype/name checkpoint identity.

## Suggested Fix

- Reject any existing child-container checkpoint when the current child is virtual.
- Perform the rejection before terminal checkpoint handling and replay/update plugin hooks.
- Add a unit regression for `ChildOperationExecutor` and a composed durable-execution test covering non-virtual to virtual replay.

## Context

Found while reviewing #698. Related review threads:

- #698 review comment 3909282767
- #698 review comment 3922629188

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Empieza por ChildOperationExecutor.check_result_status() y sigue el procesamiento de los checkpoints terminales para contextos child virtuales. Añade la regresión unitaria solicitada y una prueba compuesta de ejecución duradera; se considera terminado cuando un checkpoint no virtual se rechaza con NonDeterministicExecutionError antes de usar resultados almacenados en caché o hooks de replay/update.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
distributed-systems
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Activo
Claridad
Bien especificado
Aptitud para principiantes
72/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.