aws / aws/aws-durable-execution-sdk-python
[Feature]: SAM CLI durable emulator integration tests are ported to this repository
- Langage dominant
- Python
- Étoiles
- 53
- Forks
- 25
- Merge moyen
- 1 j 19 h
- PR mergées (30 j)
- 40
Description
### What would you like?
Context: Changes to the `aws-durable-execution-sdk-python` and `aws-durable-execution-sdk-python-testing` can often break assertions in the SAM CLI integration tests:
1. https://github.com/aws/aws-sam-cli/pull/8906
2. https://github.com/aws/aws-sam-cli/actions/runs/28089573325/job/83163914199
At the time of writing these tests in SAM CLI, the intention was to test the emulator behaviour. Now that we automatically publish an emulator image for SAM CLI from this repository, I think we can loosen some of the tests on SAM CLI side. SAM CLI doesn't need to test the specifics of our SDK behaviour, only that durable functions can be run and that the execution history can be fetched in SAM CLI. The specific behaviour of the published emulator image in conjunction with the Python SDK (such as the presence of certain fields in the execution history) can be tested in this repository rather than in SAM CLI.
We want to have stronger ownership over our SAM CLI integration as well as reduce churn for SAM CLI owners.
### Possible Implementation
1. Check emulator image test coverage in current repository
2. Check emulator image test coverage in SAM CLI
3. Reason over tests we can keep in SAM and tests we can port (define how decoupled we want to be between the durable emulator image and SAM CLI, decide minimum functionality we want to test on SAM side)
4. Port over relevant tests to current repository that we are missing
5. Remove relevant tests from SAM CLI
### Is this a breaking change?
No
### Does this require an RFC?
No
### Additional Context
This is really similar to https://github.com/aws/aws-durable-execution-sdk-python/issues/430. We could consider porting these tests and running them via the SAM CLI for this issue as well.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez par comparer la couverture des tests d’images d’émulateur dans ce dépôt avec les tests d’intégration de SAM CLI, en utilisant comme références la pull request SAM CLI liée et l’exécution du workflow. Définissez le comportement minimal de SAM CLI à conserver, portez ici la couverture spécifique à l’émulateur manquante et vérifiez que les tests de SAM CLI peuvent être réduits sans perdre la couverture de l’exécution et de l’historique des durable functions.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python
- Domaine
- cli, testing
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100