aws / aws/aws-durable-execution-sdk-python

[Testing] HttpRequest make body only bytes

Open
#448 0 comments 0 reactions 0 assignees View on GitHub
pkg:testing
Dominant language
Python
Stars
53
Forks
25
Avg merge
1d 19h
Merged PRs (30d)
40

Description

Migration from https://github.com/aws/aws-durable-execution-sdk-python-testing/issues/64

---

## overview
Follow-up from this PR https://github.com/aws/aws-durable-execution-sdk-python-testing/pull/59/files

Refactor HttpRequest so body only is type bytes, and not dict.

## acceptance criteria
1. Make HttpRequest body type bytes
2. Amend from_bytes to just update the bytes as you have it here in from_raw_bytes
3. Add a body_to_dict instance method that contains all the deserialization parsing. might need to add a _operation_name to the instance. This is what the handlers will call then, instead of "parse_json_body"

Contributor guide

Open the contributing guide

Research direction

Start with HttpRequest, comparing from_bytes with from_raw_bytes, then trace the handlers that currently call parse_json_body. Update the request body handling so it remains bytes, and ensure body_to_dict contains deserialization and the handlers use it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.