aws / aws/aws-durable-execution-sdk-java

[Bug]: Invalid checkpoint token misclassified as execution failure (message case mismatch)

未关闭 适合新手
#705 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug needs-triage pkg:sdk
主要语言
Java
星标
28
派生
11
平均合并
1 天 8 小时
30 天内合并 PR
47

描述

### Expected Behavior

When the service rejects a checkpoint call with `InvalidParameterValueException` because the checkpoint token is stale (a newer invocation superseded this one), the SDK should classify the error as an **invocation** failure (retryable). The current invocation ends, and the service starts a fresh invocation with a fresh token. The execution itself continues.

### Actual Behavior

The SDK classifies the error as an **execution** failure (non-retryable). So a stale checkpoint token fails the whole durable execution every time.

### Root Cause

The classifier matches the error message with a case-sensitive prefix check against `"Invalid Checkpoint Token"`. The service emits `"Invalid checkpoint token"` (lowercase `c` and `t`). The prefix check never matches. The error falls through to the generic 4xx branch, which is classified as an execution failure.

Service constant (`DurableExecutionsServiceSharedLib`, `ValidationErrorMessages.java` line 86, internal):

```java
public static final String INVALID_CHECKPOINT_TOKEN = "Invalid checkpoint token";
```

SDK constant (`sdk/src/main/java/software/amazon/lambda/durable/util/DurableApiErrorClassifier.java`):
https://github.com/aws/aws-durable-execution-sdk-java/blob/7f1a73ca16308d31a1e5a270e504676caf890e0b/sdk/src/main/java/software/amazon/lambda/durable/util/DurableApiErrorClassifier.java#L51

```java
private static final String INVALID_CHECKPOINT_TOKEN_MESSAGE_PREFIX = "Invalid Checkpoint Token";
```

Used in `classifyException()` via `message.startsWith(INVALID_CHECKPOINT_TOKEN_MESSAGE_PREFIX)`. The Javadoc also documents the wrong string (`4xx + "Invalid Checkpoint Token" → retryable`).

### Steps to Reproduce

1. Have the service return a 4xx `InvalidParameterValueException` whose message starts with `Invalid checkpoint token` (the real service message).
2. Pass it through the SDK error classifier.
3. Observe it is classified as an execution (non-retryable) error rather than an invocation (retryable) error.

The existing unit tests do not catch this. They construct the error with the message `"Invalid Checkpoint Token: token expired"`, which matches the SDK constant rather than the service constant.

### Proposed Fix

1. Change the SDK constant to `"Invalid checkpoint token"` so it matches the service.
2. Consider a case-insensitive comparison to protect against future drift.
3. Update the unit tests to use the real service message.

### Related

Same defect exists in all three SDKs; each gets its own issue.
- JS: aws/aws-durable-execution-sdk-js
- Python: aws/aws-durable-execution-sdk-python
- Java: aws/aws-durable-execution-sdk-java

### SDK Version

main (7f1a73c)

贡献指南

打开贡献指南

调研方向

从 sdk/src/main/java/software/amazon/lambda/durable/util/DurableApiErrorClassifier.java 开始,重点查看 INVALID_CHECKPOINT_TOKEN 前缀和 classifyException()。检查现有的单元测试,将其更新为使用 service 的小写消息,并验证 stale checkpoint token 会被分类为可重试的 invocation failure,而不是不可重试的 execution failure。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
backend
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
活跃
描述清晰度
描述清楚
新手友好度
88/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。