aws / aws/amazon-s3-encryption-client-python

Additionally remove the KMSv1 Reserved EC Key in KmsKeyring

Open
#146 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2
Forks
4
PR merge metrics
No merged PRs in 30d

Description

In Java:

```
private static final String KEY_ID_CONTEXT_KEY = "kms_cmk_id";
```

```
//= specification/s3-encryption/materials/s3-kms-keyring.md#kms-context
//# The stored encryption context with the two reserved keys removed MUST match the provided encryption context.
materialsEncryptionContextCopy.remove(KEY_ID_CONTEXT_KEY);
materialsEncryptionContextCopy.remove(ENCRYPTION_CONTEXT_ALGORITHM_KEY);
```

https://github.com/aws/amazon-s3-encryption-client-python/pull/143 points out we don't currently do this in Python.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Python KMS keyring code that compares the stored encryption context with the provided context, then compare its behavior with the Java snippets and the referenced KMS context specification. Done means both reserved keys are excluded before comparison and the relevant tests cover the KMSv1 case.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, python
Domain
cloud, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.