aws-samples / aws-samples/sample-autonomous-cloud-coding-agents

fix(compute): registry MCP assets are not substrate-portable to lambda-microvm

Aperta
#818 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
143
Fork
46
Merge medio
3g 10h
PR unite (30g)
24

Descrizione

## Problem

`resolved_assets` (#246/#665) reaches the guest on `lambda-microvm` without any strategy change — traced and confirmed: `orchestrator.ts:999` puts it on the shared `agentPayload`, the MicroVM strategy forwards that verbatim (inline or via S3), `server.py:2122 _extract_invocation_params` → `:566` → `:677` → `_spawn_background(**params)` → `_run_task_background(resolved_assets=…)` → `pipeline.py:1167 apply_resolved_assets`, which is pure-local (writes `.mcp.json`, makes no AWS calls). So the delivery path is genuinely free.

Two constraints make *execution* of those assets non-portable, and neither is recorded anywhere:

1. **443-only runtime egress.** `LambdaMicrovmCompute`'s runtime security group is `allowAllOutbound: false` with a single TCP 443 rule (`lambda-microvm-compute.ts:862-870`). A registry `mcp_server` asset whose runtime config points at any other port works on `agentcore` and `ecs` and fails on `lambda-microvm`. `apply_mcp_assets` is fail-CLOSED on load errors but cannot see a connectivity constraint, so the symptom is a task that starts normally and then cannot reach its tool.
2. **`resolved_assets` consumes the 4 096-byte `runHookPayload` budget.** That cap is exact and measured (`lambda-microvm-strategy.ts:100-125`), and it is the branch point between inline and S3-pointer delivery. Adding asset entries shifts which tasks inline. Not a bug — the S3 path is already dominant — but it is an untested interaction: no test covers an envelope that crosses 4 096 bytes *because of* `resolved_assets`.

## Expected

- Document the 443-only constraint where registry assets are described (`docs/design/REGISTRY.md`) and in the `lambda-microvm` section of `COMPUTE.md` / `DEPLOYMENT_GUIDE.md`.
- Decide whether to validate it: either a synth/onboarding-time check that a pinned `mcp_server` asset's runtime is 443-reachable, or an explicit "not supported on this backend" note.
- Add a strategy test that pushes an envelope over 4 096 bytes via `resolved_assets` specifically and asserts the S3-pointer branch is taken.

Refs #645, #246, #665. Blocked by nothing; P2.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia da lambda-microvm-strategy.ts:100-125 e segui il percorso degli asset attraverso orchestrator.ts:999, server.py:2122 e pipeline.py:1167; esamina i test della strategia esistenti ed eseguili. È completato quando la limitazione al solo 443 è documentata in docs/design/REGISTRY.md, COMPUTE.md e DEPLOYMENT_GUIDE.md e un test copre il ramo S3-pointer oltre 4.096 byte forzato da resolved_assets.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
aws, python, typescript
Ambito
cloud, documentation, infrastructure, testing
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
55/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.