aws-samples / aws-samples/sample-autonomous-cloud-coding-agents
agent: Fail-fast preflight verify step before run_agent
- Lingua principale
- TypeScript
- Stelle
- 143
- Fork
- 46
- Merge medio
- 3g 9h
- PR unite (30g)
- 20
Descrizione
## Component
Agent (Python runtime)
## Describe the feature
Support an explicit **`verify_build` or `verify_lint` step before the first `run_agent`** that **fails the task without invoking the LLM** when the repo is already broken.
```yaml
steps:
- { kind: clone_repo, name: setup }
- { kind: verify_build, name: preflight, gate: strict, on_failure: fail }
- { kind: run_agent, name: implement }
- { kind: verify_build, name: build, gate: regression_only }
- { kind: ensure_pr, name: open_pr, strategy: create }
```
## Use case
**What exists today (not sufficient):**
- `clone_repo` / `setup_repo` already runs `mise run build` and `mise run lint` deterministically and records `build_before` / `lint_before` in `RepoSetup`.
- If the initial build fails, the task **still proceeds to `run_agent`** — failure is noted in setup notes and prompts tell the agent to run build, but there is no workflow-level fail-fast gate.
- Post-agent `verify_build` runs only after the agent consumes tokens.
**Gap:** Operators need a declarative, deterministic preflight gate — not prompt guidance — to skip LLM execution when the tree is already red.
Orchestrator pre-flight ([ARCHITECTURE.md](https://github.com/aws-samples/sample-autonomous-cloud-coding-agents/blob/main/docs/design/ARCHITECTURE.md)) covers GitHub reachability; this covers **repo health after clone**.
## Proposed solution
1. **Validator** — If a `verify_*` step appears before `run_agent`, `gate` must be `strict` or `regression_only` (not `informational`); record baseline in `workflow_state.json` for post-agent `regression_only` compare.
2. **Runner** — Step order already supported; add test proving preflight failure never invokes `run_agent`.
3. **Cost** — `clone_repo` already runs build; consider skipping duplicate full build in clone when a preflight `verify_build` immediately follows, or document opt-in on workflows only.
4. **Docs** — WORKFLOWS.md preflight pattern + cost trade-off.
5. **Opt-in** — Enable on `coding/new-task-v1` only after cold-start cost measurement.
## Other information
- Forbidden when `requires_repo: false` (existing validator rule).
- Related: #457 (post-agent fix loops — complementary).
## Acknowledgements
- [ ] I may be able to implement this feature
- [ ] This might be a breaking change
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Leggi docs/design/ARCHITECTURE.md e WORKFLOWS.md, quindi traccia gli entry point dei validator e runner verify_* intorno a clone_repo e run_agent. Aggiungi la coverage per un preflight fallito che non invochi mai run_agent, registra le baseline di workflow_state.json e documenta il pattern di preflight e il compromesso relativo ai costi di build.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- python, typescript
- Ambito
- backend, documentation, tooling
- Tipo di issue
- Funzionalità
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 55/100