aws-samples / aws-samples/sample-autonomous-cloud-coding-agents

chore(eslint): re-enable @cdklabs rules after plugin fixes deprecated context.getFilename()

Aperta
#170 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement tooling
Lingua principale
TypeScript
Stelle
143
Fork
46
Merge medio
3g 9h
PR unite (30g)
20

Descrizione

## Summary

Four `@cdklabs/eslint-plugin` rules are disabled in `cdk/eslint.config.mjs` because they use the deprecated `context.getFilename()` API which was removed in ESLint 10. Re-enable them when cdklabs publishes a fix.

## Disabled rules

| Rule | Purpose |
|------|---------|
| `@cdklabs/no-core-construct` | Prevents use of deprecated core Construct class |
| `@cdklabs/invalid-cfn-imports` | Validates CloudFormation import patterns |
| `@cdklabs/no-literal-partition` | Catches hardcoded AWS partition strings |
| `@cdklabs/no-invalid-path` | Validates path references |

## Root cause

ESLint 10 removed `context.getFilename()` (deprecated since ESLint 9.x). The replacement is `context.filename`. The `@cdklabs/eslint-plugin@2.0.6` (latest as of 2026-05-22) still calls the removed API, causing runtime errors during linting.

`promiseall-no-unbounded-parallelism` remains enabled as it doesn't use the deprecated API.

## Action required

1. Monitor `@cdklabs/eslint-plugin` releases for a version that uses `context.filename`
2. When published: bump the dependency and remove the `off` overrides from `cdk/eslint.config.mjs`
3. Re-run `mise //cdk:eslint` — the 3 file-level `@cdklabs/no-literal-partition` suppressions in `cdk/src/bootstrap/policies/` will become active again

## Upstream

- Package: https://www.npmjs.com/package/@cdklabs/eslint-plugin
- Current: 2.0.6 (peerDeps: `eslint >=9 <11` — claims ESLint 10 support but uses removed API)
- Consider filing an upstream issue at the cdklabs GitHub org if not already tracked

## Related

- #169 — ESLint 10 upgrade (this was discovered during migration)

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia da cdk/eslint.config.mjs e ispeziona le regole @cdklabs disabilitate e la versione della dipendenza. Monitora @cdklabs/eslint-plugin per una release che sostituisca context.getFilename(), quindi aggiorna la dipendenza, rimuovi gli override off ed esegui mise //cdk:eslint. Conferma che le soppressioni in cdk/src/bootstrap/policies/ siano nuovamente attive senza errori a runtime.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
eslint, typescript
Ambito
tooling
Tipo di issue
Refactoring
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.