aws-samples / aws-samples/lambdaedge-openidconnect-samples

Cloudfront distribution ID not known when creating secret

未关闭
#71 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
73
派生
22
平均合并
19 小时 45 分钟
30 天内合并 PR
1

描述

One of the initials steps is to create a secret with a placeholder value. However, the secret name is:
"cloudfront/DISTRIBUTION_ID"
with DISTRIBUTION_ID to be substituted with the actual cloudfront distribution ID
doc: https://github.com/aws-samples/lambdaedge-openidconnect-samples/blob/master/docs/baseconfiguration.md

Previously the secret name was to be placed in a sm-key.txt file. Looks like this has changed and the secret is simply
"cloudfront/DISTRIBUTION_ID"

The code has been updated to look for this value. https://github.com/aws-samples/lambdaedge-openidconnect-samples/blob/master/src/js/auth.js#L241

However, the distribution_ID is not know when the secret is created. And, the secret ARN must be provided to deploy the stack (circular dependency).

Am I missing something?

贡献指南

打开贡献指南

调研方向

从 docs/baseconfiguration.md 以及 src/js/auth.js 第 241 行附近的查找开始。跟踪 CloudFront 分发 ID 和 secret ARN 何时在堆栈部署期间变得可用,然后确认一个能够避免循环依赖的文档化工作流。

由索引模型根据 Issue 内容生成。

评估

技术栈
aws, javascript
领域
cloud, devops
Issue 类型
缺陷
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
28/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。