aws-samples / aws-samples/aws-serverless-developer-experience-workshop-python
Bug: publication_approved never accesses errors param
- Dominant language
- Python
- Stars
- 47
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
### Expected Behaviour
publication_approved method never access `errors`
### Current Behaviour
No issue, parameter is never used
### Code snippet
```csharp
def lambda_handler(event, context):
"""Main entry point for Property Approval lambda function
Parameters
----------
event : API Gateway Lambda Proxy Request
The event passed to the function.
context : AWS Lambda Context
The context for the Lambda function.
Returns
-------
Success message upon successful storage of the approval outcome into DynamoDB
"""
logger.info(event)
errors = None if 'workflowErrors' not in event['detail'] else event['detail'].pop('workflowErrors')
# Deserialize event into strongly typed object
awsEvent:AWSEvent = Marshaller.unmarshall(event, AWSEvent) # type: ignore
detail:PublicationEvaluationCompleted = awsEvent.detail # type: ignore
return publication_approved(detail, errors)def lambda_handler(event, context):
"""Main entry point for Property Approval lambda function
Parameters
----------
event : API Gateway Lambda Proxy Request
The event passed to the function.
context : AWS Lambda Context
The context for the Lambda function.
Returns
-------
Success message upon successful storage of the approval outcome into DynamoDB
"""
logger.info(event)
errors = None if 'workflowErrors' not in event['detail'] else event['detail'].pop('workflowErrors')
# Deserialize event into strongly typed object
awsEvent:AWSEvent = Marshaller.unmarshall(event, AWSEvent) # type: ignore
detail:PublicationEvaluationCompleted = awsEvent.detail # type: ignore
return publication_approved(detail, errors)
```
### Possible Solution
_No response_
### Steps to Reproduce
N/A
### Debugging logs
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.