aws-samples / aws-samples/aws-lambda-redirection-at-edge
Document and code doesnt work as expected
- Vorherrschende Sprache
- JavaScript
- Sterne
- 46
- Forks
- 15
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Following this guide:
https://aws.amazon.com/blogs/networking-and-content-delivery/handling-redirectsedge-part2/
Recommends a JSON like this one:
```
{
"uris":[
{
"original":"/index1.html",
"redirect":"/index2.html?test=1",
"statusCode":"302",
"startTime":"2017-10-23T13:15",
"endTime":""
}],
"wildcards":[
{
"original":"/index6/*",
"redirect":"/index7/*",
"statusCode":"301",
"startTime":"2017-10-23T01:01",
"endTime":"2017-10-25T01:01"
}],
"querystrings":[
{
"original":"campaign=1",
"redirect":"/index4.html?test",
"statusCode":"301",
"startTime":"",
"endTime":""
}]
}
```
But that json is wrong,
Two possible options:
1) Change the json in the doc to modify the "uris" key and name it "rules"
2) Change the code so in this line:
https://github.com/aws-samples/aws-lambda-redirection-at-edge/blob/73b0876351679adc63b1d245b56a990c05c19081/lambda/origin-request-function/rules.js#L31
rename from:
```
this.ruleset.rules
to
this.ruleset.uris
```
Other than that, thanks for this example :D
Beitragsleitfaden
Rechercherichtung
Start by comparing the JSON example in the linked AWS guide with lambda/origin-request-function/rules.js at line 31, where the ruleset key is read. Decide which key should be authoritative, update the documentation or code consistently, and verify that the sample configuration is accepted and used by the redirect handler.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- aws, javascript
- Bereich
- backend, cloud
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 48/100