aws-samples / aws-samples/aws-lambda-redirection-at-edge

Document and code doesnt work as expected

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
46
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Following this guide:
https://aws.amazon.com/blogs/networking-and-content-delivery/handling-redirectsedge-part2/

Recommends a JSON like this one:
```
{
"uris":[
{
"original":"/index1.html",
"redirect":"/index2.html?test=1",
"statusCode":"302",
"startTime":"2017-10-23T13:15",
"endTime":""
}],
"wildcards":[
{
"original":"/index6/*",
"redirect":"/index7/*",
"statusCode":"301",
"startTime":"2017-10-23T01:01",
"endTime":"2017-10-25T01:01"
}],
"querystrings":[
{
"original":"campaign=1",
"redirect":"/index4.html?test",
"statusCode":"301",
"startTime":"",
"endTime":""
}]
}
```

But that json is wrong,
Two possible options:

1) Change the json in the doc to modify the "uris" key and name it "rules"

2) Change the code so in this line:
https://github.com/aws-samples/aws-lambda-redirection-at-edge/blob/73b0876351679adc63b1d245b56a990c05c19081/lambda/origin-request-function/rules.js#L31

rename from:
```
this.ruleset.rules
to
this.ruleset.uris
```

Other than that, thanks for this example :D

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.