aws-samples / aws-samples/aws-codedeploy-samples

Various issues in scripts

未关闭
#86 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Shell
星标
639
派生
778
PR 合并指标
30 天内没有已合并 PR

描述

I've noticed that [shellcheck](https://www.shellcheck.net/) picks up numerous real issues with the scripts in this repo. For example this is a commit fixing only the issue of `local` not propagating the return value from assignment (which means the `$?` checks after it will never fail) https://github.com/viraptor/aws-codedeploy-samples/commit/9d55660264c544080bf6c3e90972db10e90ef21a
There are a few others as well.

It looks like the scripts could use a cleanup beyond a single PR.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。