aws-samples / aws-samples/aws-codedeploy-samples

register_from_elb should be at hook ValidateService

Open
#85 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
639
Forks
778
PR merge metrics
No merged PRs in 30d

Description

Noticed that currently register_from_elb is placed in the hook ApplicationStart while it would make more sense to put it at ValidateService?
If Validate fails, you do not want to register it again to the ELB

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.