aws-cloudformation / aws-cloudformation/cloudformation-cli-java-plugin

Fix misleading `getDesiredResourceTags` behavior

Ouverte
#366 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Java
Étoiles
30
Forks
48
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/blob/75133adfd5b82c347bf31579b09e82750b47cde7/src/main/java/software/amazon/cloudformation/AbstractWrapper.java#L536-L549

Here we claim `getDesiredResourceTags` return User-defined tags. Intuitively readers would assume it's for user tags only.

However, I have noticed system tags such as `aws:cloudformation:stackid` is being added in the returned results while testing my CFN stack. Given we already have `request.getRequestData().getSystemTags()` method for system tags, please consider to either update the code comments explaining why these non User-defined tags are here, or provide another method that will only return user tags to avoid confusions.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.